Skip to content

make tests for i3lock and betterlockscreen POSIX compliant #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thatjames wants to merge 5 commits into
base: master
Choose a base branch
from
Open

make tests for i3lock and betterlockscreen POSIX compliant #200

thatjames wants to merge 5 commits into from
+133 −13

Conversation

@thatjames
Copy link

@thatjames thatjames commented Jan 2, 2026 •
edited
Loading

The following check

if [[ -x '/usr/bin/betterlockscreen' ]]; then
  betterlockscreen -l
elif [[ -x '/usr/bin/i3lock' ]]; then
  i3lock
fi

is not portable. For example, this check fails on nixos due to the way nix symlinks binaries.

command is the POSIX compliant manner to test for binaries. This fixes the issue I have with my nixos build, and should make it easier for newcomers to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thatjames